Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blas and sparse unit tests for LayoutRight #973

Closed
e10harvey opened this issue May 12, 2021 · 1 comment
Closed

Fix blas and sparse unit tests for LayoutRight #973

e10harvey opened this issue May 12, 2021 · 1 comment
Assignees
@e10harvey
Labels
bug fixed-in-develop bug

Comments

@e10harvey
Copy link
Contributor

e10harvey commented May 12, 2021 •
edited
Loading

While testing the changes in #965, I found that several blas and sparse unit tests do not pass LayoutRight views into the KokkosBlas and KokkosSparse routines; instead subview was used on the LayoutRight view which ultimatley passed in LayoutStride views to the KokkosBlas routines. In some of the routines, including KokkosSparse, LayoutLeft was hard coded.
@e10harvey e10harvey added the bug label May 12, 2021
@e10harvey e10harvey self-assigned this May 12, 2021
@e10harvey e10harvey mentioned this issue May 12, 2021
Merged
@e10harvey
Copy link
Contributor Author

Addressed via #965.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e10harvey e10harvey

Labels
bug fixed-in-develop bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@e10harvey