-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Try pom packaging if jar packaging fails #483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
jmle
changed the title
Try pom packaging if jar packaging fails
🐛 Try pom packaging if jar packaging fails
Feb 5, 2024
shawn-hurley
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
some nits but nothing that is drastic
shawn-hurley
reviewed
Feb 8, 2024
shawn-hurley
reviewed
Feb 8, 2024
shawn-hurley
reviewed
Feb 8, 2024
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
shawn-hurley
reviewed
Feb 8, 2024
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
pranavgaikwad
pushed a commit
to pranavgaikwad/analyzer-lsp
that referenced
this pull request
Feb 21, 2024
Fixes konveyor#482 --------- Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
pranavgaikwad
added a commit
that referenced
this pull request
Feb 21, 2024
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #482