JavaFX

[koppor]

• Check if CLI still works. If not rewrite so that command line is started using JavaFX mechansims (@JabRef/StuPro)
• Check if JabRef can still be packaged using Install4J (@koppor)
• Check that it runs under most linux distributions (@JabRef/StuPro)

[koppor]

openjfx seems to be the package for Ubuntu

xenial (java): JavaFX/OpenJFX 8 - Rich client application platform for Java [universe] 8u60-b27-4

[boceckts]

On Ubuntu I would also test oracle jdk. Oracle JDK can be installed quite easily and doesn't need any additional libraries. The the jdks can be switched by using sudo update-alternatives --config java

[bruehldev]

Thanks a lot, i will additionally add some test cases in the test protocol for openjfx.
Is there a simple solution to test install4j without installing the framework?
Somehow i can't run install4j. Not even on the upstream master branch.
I got this error message:

What went wrong:
Execution failed for task ':install4j'.

property "projectFile" must be set

Where can i set this property?

[koppor]

Install4J can only tested by the developers of JabRef. It is automatically built if someone pushes to a branch at http://github.com/JabRef/jabref/. Then, it is available at https://builds.jabref.org/ <branchname>. In our case soon at https://builds.jabref.org/javafx/

Regarding your branch https://github.com/bruehldev/jabref/tree/javafxTest - could you merge in http://github.com/JabRef/jabref/javafx? (Minor thing: I could not use your branch as the CHANGELOG.md was corrupted during merge - the changelog of a released version was changed)

Before merging, could you check http://github.com/JabRef/jabref/javafx and say what could be possibly wrong there? Why so many tests are failing?

[tobiasdiez]

@koppor I think @bruehldev wants to create an installer, i.e. "release" JabRef. @bruehldev did you followed the steps outlined in the wiki?

[bruehldev]

@koppor. I had the same issues on my branch and it's getting worse after the merge with the upstream/master branch. Most of the test's fail with with the error message:

net.sf.jabref.logic.cleanup.CleanupWorkerTest > cleanupCasesAddsBracketAroundAluminiumGalliumArsenid FAILED
java.lang.NoClassDefFoundError: Could not initialize class net.sf.jabref.logic.protectedterms.ProtectedTermsLoader
at net.sf.jabref.preferences.JabRefPreferences.(JabRefPreferences.java:687)
at net.sf.jabref.preferences.JabRefPreferences.getInstance(JabRefPreferences.java:462)
at net.sf.jabref.logic.cleanup.CleanupWorkerTest.setUp(CleanupWorkerTest.java:53)

I tried to find the cause of the error but i couldn't so far. I will merge my branch after i finished all javafx tests. Maybe @boceckts knows more.

@Braunch and me think it had something to do with
https://github.com/JabRef/jabref/blob/javafx/src/main/java/net/sf/jabref/logic/protectedterms/ProtectedTermsLoader.java#L44

@tobiasdiez i created a .jar file for testing by using releaseJar with gradle. I just wondered how i can integrate Install4J. It's good to know that install4j is automatically built in JabRef.

[koppor]

The cleanupCasesAddsBracketAroundAluminiumGalliumArsenid is fixed in the master branch (JabRef#1706)

[koppor]

Install4J can only be used by the developers of JabRef as only we have the license key. As the license key is available also on TravisCI, all builds triggered by the JabRef developers produce an installer. As soon as JabRef's javafx branch compiles, a build is produced at https://builds.jabref.org/javafx.

[bruehldev]

@koppor
I ckecked the CLI on every kind of operating system and it worked perfectly .(https://github.com/bruehldev/JabRef---Javafx-production-test/blob/master/JavaFXProduktionstest.md#cli).

I couldn't run and test the Install4J build, because there were some issues left.
If @tobiasdiez solves the last failing test in 'JabRef#1753' i can proceed with that test.

[koppor]

JabRef 4.0 uses JavaFX.