Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web search results should render the BibTeX too #560

Closed
koppor opened this issue Apr 24, 2022 · 11 comments · Fixed by JabRef/jabref#10784
Closed

Web search results should render the BibTeX too #560

koppor opened this issue Apr 24, 2022 · 11 comments · Fixed by JabRef/jabref#10784

Comments

@koppor
Copy link
Owner

koppor commented Apr 24, 2022

Example search "Vino4TOSCA" on "Collection of Computer Sciene Bibliographies"

image

As user, I wonder, which entry contains the most information.

I would like to have a) the BibTeX information or b) a list of fields (as soon as I click on an entry).

@nooynayr
Copy link

nooynayr commented Oct 13, 2023

Hello, I've gone through the contributing page and the setup page. Would I be able to work on this issue?

I'd like to maybe have some pointers on where to start with this issue if possible as well?

@taliashark77
Copy link

Hello, I would also be interested in working on this issue for my university assignment, please let me know it would be ok for me to work on this

@koppor
Copy link
Owner Author

koppor commented Oct 23, 2023

@nooynayr Was first, sorry @taliashark77.

@nooynayr Please give feedback within two days if you really work on this. Otherwise, I will free up the issue again.

@nooynayr
Copy link

@koppor I've looked into the repo and I've compiled the project so that I can use JabRef. Which classes would I need to look into in order to resolve this issue? I've looked at the search folder under gui so far.

@koppor
Copy link
Owner Author

koppor commented Oct 23, 2023

@nooynayr IntelliJ offers Ctrl+Shift+F to search for text. You can use the text "Select the entries to be imported" to find the classes. Maybe you should also give JavaFX give a read: https://devdocs.jabref.org/code-howtos/javafx.html

@nooynayr
Copy link

@koppor Could you unassign me from this issue?

@MrMachiei
Copy link

Hi all, hope everything is going well! I'm really interested in tackling this issue as a beginner, could I take it?

@koppor
Copy link
Owner Author

koppor commented Nov 27, 2023

@MrMachiei Sure! I assigned you. Looking forward!

@MrMachiei
Copy link

MrMachiei commented Jan 7, 2024

Hi @koppor, I'm working on the issue now, could you please give me an example of how would you like to Bibtex information be presented? Should it be all BibTeX data presented as a row after the authors or something else?

@koppor
Copy link
Owner Author

koppor commented Jan 9, 2024

@MrMachiei Just the plain BibTeX, like in the entry editor.

image

Place it below the list and the buttons ("Select all entries", ...)


The bibfile used is https://github.com/JabRef/jabref/blob/main/src/test/resources/testbib/Chocolate.bib.

@MrMachiei
Copy link

Hi @koppor, I created the PR: JabRef#10784

koppor added a commit that referenced this issue Jan 29, 2024
* BibTeX information in web search import screen. (#560)

* BibTeX information in web search import screen - add toggle button (#560)

* fixing style issues

* fixing some repo issues (#560)

* move logic to viewModel (#560)

* changing headers (#560)

* fix typo (#560)

* further changes... (#560)

* Refine text

---------

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants