Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit hooks #134

Open
loboda4450 opened this issue Jul 9, 2024 · 3 comments
Open

Pre-commit hooks #134

loboda4450 opened this issue Jul 9, 2024 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@loboda4450
Copy link
Collaborator

loboda4450 commented Jul 9, 2024

As in my other project (click) I have configured pre-commit hooks that haven't allowed me to push to the repo if hooks were not successful. Actually I have literally 0 exprience in Go, but I believe this would be so beneficial. They could be also reflected in CIs.

@loboda4450 loboda4450 added enhancement New feature or request question Further information is requested labels Jul 9, 2024
@bouassaba
Copy link
Member

From my side it sounds good, I used git hooks before, they automate code quality tasks pretty well.
We could also ask the opinion of @dsonck92 on this, as he already setup for us golangci-lint, he must have great knowledge on this.

@dsonck92
Copy link
Collaborator

dsonck92 commented Jul 9, 2024

Heh, well, I'm all for it. One outstanding point regarding golangci-lint specifically, there is a bug somewhere with the caching system, which may produce false positives. This is mostly triggered by the ireturn linter. There is some discussion on whether the ireturn linter is actually something you want as there are use cases where you do want to return an interface.

@bouassaba
Copy link
Member

@loboda4450 @dsonck92 Do we still want to have this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants