Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry Support #478

Closed
yaronp opened this issue Apr 13, 2022 · 17 comments
Closed

OpenTelemetry Support #478

yaronp opened this issue Apr 13, 2022 · 17 comments
Labels

Comments

@yaronp
Copy link

yaronp commented Apr 13, 2022

As a user of Dynatrace, I would like that krakend-ce to support OpenTelemetry exporter integration so we can instrument, generate, collect, and export telemetry data (metrics, logs, and traces) to Dynatrace (or other OpenTelemetry supported platform).

It will also be nice if, where possible out-of-the-box instrumentation libraries will be supported (see https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrumentation).

@kpacha
Copy link
Member

kpacha commented Jun 16, 2022

we are waiting for the project to be stable, complete and mature before switching from opencensus to opentelemetry, but it's in our roadmap.

I'm keeping this open until we switch

cheers!

@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@rottenbytes
Copy link

Opentelemetry is stable now right ?

@kpacha
Copy link
Member

kpacha commented Mar 22, 2023

No, it is not

image

@rottenbytes
Copy link

It is for traces (which is why I'm looking into it)

@alombarte
Copy link
Member

Unfortunately, traces are a third of the requirements of this issue. This component will likely require much effort, and I don't see it implemented in CE in the short term, as OpenCensus is already providing all the functionality (and is stable). Expanding the library to onboard more providers is not a priority of the open-source product.

@rottenbytes
Copy link

Noted. Thanks !

@github-actions
Copy link

Hi, thank you for bringing this issue to our attention.

Many factors influence our product roadmaps and determine the features, fixes, and suggestions we implement.
When deciding what to prioritize and work on, we combine your feedback and suggestions with insights from our development team, product analytics, research findings, and more.

This information, combined with our product vision, determines what we implement and its priority order. Unfortunately, we don't foresee this issue progressing any further in the short-medium term, and we are closing it.

While this issue is now closed, we continue monitoring requests for our future roadmap, including this one.

If you have additional information you would like to provide, please share.


This is an automated comment. Responding to the bot or mentioning it won't have any effect

@iborysenko
Copy link

Hi @alombarte , according to https://opentelemetry.io/blog/2023/sunsetting-opencensus/
Make sense to add OTEL support for these project.
Do you have any plans for it now?

@Harnoor7
Copy link

@alombarte @kpacha Is open-telemetry support in this year's roadmap or has any work started? If not, I can start working on adding Opentelemetry support to this project.

@alombarte
Copy link
Member

Hi @Harnoor7, any help is welcome.

This year's roadmap has only two months left, so there won't be OpenTelemetry in 2023. We are about to release KrakenD 2.5, and there won't be an eventual KrakenD 2.6 until 2024.

The deprecation of OpenCensus, while OTEL does not provide (even close) the same level of stable functionality, is something I personally don't understand, but it is what it is, and we will write a new component for OTEL.

I am reopening this task for reference, but the development will continue here: https://github.com/krakend/krakend-otel

Thank you

@alombarte alombarte reopened this Oct 30, 2023
@alombarte alombarte added roadmap and removed wontfix labels Oct 30, 2023
@Harnoor7
Copy link

Currently, the opentelemetry otelhttp package library which is equivalent to the opencensus ochttp library (used in Krakend) does not expose client-side metrics which is used in Krakend here. I was working on replacing ochttp with otelhttp but now will have to wait until client-side metric capture support is added as part of this PR.

@dhontecillas
Copy link
Contributor

@Harnoor7 , there is work in progress to support instrumenting the client with opentelemetry. That support will be added in a separate library, so it can be used not only in krakend-ce but also in other projects. That code will be hosted in this repo: https://github.com/krakend/krakend-otel . So, I would advice you to not move forward on adding that support until we have some basic stable implementation in that repo. You can star / watch the repo, so you get notified when we have some working implementation there.

@Harnoor7
Copy link

@dhontecillas Thanks for the update. I also did some implementation for Opentelemetry integration, Will wait for your implementation to complete then. If you don't mind, Possible to share a rough timeline as to when we can have a working implementation?

@dhontecillas
Copy link
Contributor

@Harnoor7 we are actively working on it, but given that the end of the year holidays are so close, I would say that the PR in this repo will be ready by the first half of January. And it might get merged, and used in KrakenD Community in the next release.

@Harnoor7
Copy link

Thanks, this helps!

@alombarte
Copy link
Member

Hello @yaronp,

With the last release, you should be able to integrate Dynatrace on KrakenD. Here are the docs: https://www.krakend.io/docs/telemetry/opentelemetry/

Please share any follow-up snippets of code, recommendations, or guidance you have once you implement it. I am closing this task.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants