-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry Support #478
Comments
we are waiting for the project to be stable, complete and mature before switching from opencensus to opentelemetry, but it's in our roadmap. I'm keeping this open until we switch cheers! |
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
Opentelemetry is stable now right ? |
It is for traces (which is why I'm looking into it) |
Unfortunately, traces are a third of the requirements of this issue. This component will likely require much effort, and I don't see it implemented in CE in the short term, as OpenCensus is already providing all the functionality (and is stable). Expanding the library to onboard more providers is not a priority of the open-source product. |
Noted. Thanks ! |
Hi, thank you for bringing this issue to our attention. Many factors influence our product roadmaps and determine the features, fixes, and suggestions we implement. This information, combined with our product vision, determines what we implement and its priority order. Unfortunately, we don't foresee this issue progressing any further in the short-medium term, and we are closing it. While this issue is now closed, we continue monitoring requests for our future roadmap, including this one. If you have additional information you would like to provide, please share.
|
Hi @alombarte , according to https://opentelemetry.io/blog/2023/sunsetting-opencensus/ |
@alombarte @kpacha Is open-telemetry support in this year's roadmap or has any work started? If not, I can start working on adding Opentelemetry support to this project. |
Hi @Harnoor7, any help is welcome. This year's roadmap has only two months left, so there won't be OpenTelemetry in 2023. We are about to release KrakenD 2.5, and there won't be an eventual KrakenD 2.6 until 2024. The deprecation of OpenCensus, while OTEL does not provide (even close) the same level of stable functionality, is something I personally don't understand, but it is what it is, and we will write a new component for OTEL. I am reopening this task for reference, but the development will continue here: https://github.com/krakend/krakend-otel Thank you |
Currently, the opentelemetry |
@Harnoor7 , there is work in progress to support instrumenting the client with opentelemetry. That support will be added in a separate library, so it can be used not only in krakend-ce but also in other projects. That code will be hosted in this repo: https://github.com/krakend/krakend-otel . So, I would advice you to not move forward on adding that support until we have some basic stable implementation in that repo. You can star / watch the repo, so you get notified when we have some working implementation there. |
@dhontecillas Thanks for the update. I also did some implementation for Opentelemetry integration, Will wait for your implementation to complete then. If you don't mind, Possible to share a rough timeline as to when we can have a working implementation? |
@Harnoor7 we are actively working on it, but given that the end of the year holidays are so close, I would say that the PR in this repo will be ready by the first half of January. And it might get merged, and used in KrakenD Community in the next release. |
Thanks, this helps! |
Hello @yaronp, With the last release, you should be able to integrate Dynatrace on KrakenD. Here are the docs: https://www.krakend.io/docs/telemetry/opentelemetry/ Please share any follow-up snippets of code, recommendations, or guidance you have once you implement it. I am closing this task. Thank you! |
As a user of Dynatrace, I would like that krakend-ce to support OpenTelemetry exporter integration so we can instrument, generate, collect, and export telemetry data (metrics, logs, and traces) to Dynatrace (or other OpenTelemetry supported platform).
It will also be nice if, where possible out-of-the-box instrumentation libraries will be supported (see https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrumentation).
The text was updated successfully, but these errors were encountered: