Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues/49 'Reference error: window undefined' error in SSR components #62

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

ukalbhor
Copy link
Contributor

@ukalbhor ukalbhor commented Dec 13, 2022

Fixes #49

image

@westeezy westeezy requested a review from a team December 13, 2022 22:50
Copy link
Contributor

@gregjopa gregjopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dtjones404
Copy link
Contributor

Hi @ukalbhor, can you revert the dist/ changes? We build during our publish process (I know it's weird 😅).

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.56%. Comparing base (f625bea) to head (31db255).
Report is 35 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   69.34%   69.56%   +0.22%     
==========================================
  Files           5        5              
  Lines         137      138       +1     
==========================================
+ Hits           95       96       +1     
  Misses         42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ukalbhor
Copy link
Contributor Author

@dtjones404 removed dist/

@wsbrunson wsbrunson merged commit 1420083 into krakenjs:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSR broken with latest version 4.0.32
5 participants