Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update metric type to match beaver-logger-paypal #77

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

wsbrunson
Copy link
Member

No description provided.

@wsbrunson wsbrunson requested a review from a team August 18, 2023 17:15
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.42%. Comparing base (528d080) to head (68f4850).
Report is 16 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   87.23%   86.42%   -0.81%     
==========================================
  Files           6        6              
  Lines         564      523      -41     
==========================================
- Hits          492      452      -40     
+ Misses         72       71       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@jshawl jshawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks great!!!

@wsbrunson wsbrunson merged commit f52accb into main Aug 18, 2023
1 check passed
@wsbrunson wsbrunson deleted the update-metric-type branch August 18, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants