From 10e43f1eaf8c698a0758d428a4d19e1f17b0df2f Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Mon, 5 Aug 2024 20:13:00 +0200 Subject: [PATCH 1/3] Update Windows CI workflow for PHP 8.4 We also update to the latest actions: * setup-php-sdk v9 is required for PHP 8.4 support * actions/checkout v4 and actions/upload-artifact v4 are not deprecated --- .github/workflows/windows.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index b81aa31..0bc76ee 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -7,7 +7,7 @@ jobs: shell: cmd strategy: matrix: - version: ["8.0", "8.1", "8.2", "8.3"] + version: ["8.0", "8.1", "8.2", "8.3", "8.4"] arch: [x64] ts: [ts] if: success() || failure() @@ -15,10 +15,10 @@ jobs: name: Windows, PHP v${{matrix.version}} steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Setup PHP id: setup-php - uses: php/setup-php-sdk@v0.8 + uses: php/setup-php-sdk@v0.9 with: version: ${{matrix.version}} arch: ${{matrix.arch}} @@ -55,7 +55,7 @@ jobs: copy ..\deps\COPYING .install\COPYING.PTHREADS copy ..\deps\bin\* .install - name: Upload artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: parallel-${{matrix.version}} path: .install From 6b3e20aa4370008730c40977eb8ffd31e9fadc52 Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Mon, 5 Aug 2024 20:33:53 +0200 Subject: [PATCH 2/3] Update to pthreads V3 We also use the new download server to fetch that dependency. --- .github/workflows/windows.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 0bc76ee..54077f7 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -25,8 +25,8 @@ jobs: ts: ${{matrix.ts}} - name: Fetch dependencies run: | - curl -LO https://windows.php.net/downloads/pecl/deps/pthreads-2.11.0-vs16-${{matrix.arch}}.zip - 7z x pthreads-2.11.0-vs16-${{matrix.arch}}.zip -o..\deps + curl -LO https://downloads.php.net/~windows/pecl/deps/pthreads-3.0.0-vs16-${{matrix.arch}}.zip + 7z x pthreads-3.0.0-vs16-${{matrix.arch}}.zip -o..\deps - name: Enable Developer Command Prompt uses: ilammy/msvc-dev-cmd@v1 with: From bf7231975666e8ebbccdab09395d9b4d8b2fe73e Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Mon, 5 Aug 2024 20:34:57 +0200 Subject: [PATCH 3/3] Use windows-2022 instead of windows-latest That might prevent issues when a new windows runner is made available by Github. --- .github/workflows/windows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 54077f7..0f7bd12 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -11,7 +11,7 @@ jobs: arch: [x64] ts: [ts] if: success() || failure() - runs-on: windows-latest + runs-on: windows-2022 name: Windows, PHP v${{matrix.version}} steps: - name: Checkout