Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU recommendation JSON in Docs #1257

Conversation

bharathappali
Copy link
Member

Description

Adds the sample JSON response which has GPU recommendations

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

No tests needed as it's a doc change

  • New Test X
  • Functional testsuite

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

None

Signed-off-by: bharathappali <abharath@redhat.com>
@bharathappali bharathappali self-assigned this Aug 13, 2024
@bharathappali bharathappali changed the title Add GPU recommendation JSON Add GPU recommendation JSON in Docs Aug 13, 2024
"notifications": {
"111104": {
"type": "info",
"message": "Fixed Term Recommendations Available",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this fixed term recommendations always?

"amount": 1.1090952192E9,
"format": "bytes"
},
"nvidia.com/mig-4g.20gb": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will cpu also be available along with GPU recommendations?

"format": "bytes"
}
},
"2024-08-02T10:07:09.000Z": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format is missing here? Is box plots applicable for GPU, then we should have GPU usage also isn't it?

@bharathappali
Copy link
Member Author

PR #1325 will be adding the correct changes, closing this PR as it's no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants