Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command line syntax #442

Closed
jtamames opened this issue Sep 26, 2024 · 7 comments · Fixed by #443
Closed

command line syntax #442

jtamames opened this issue Sep 26, 2024 · 7 comments · Fixed by #443

Comments

@jtamames
Copy link

Hello
This is likely a silly question, but I am having problems with the command to run the program as you put it:

strobealign -t 60 01.H1.fasta H1.current_1.gz H1.current_2.gz | samtools sort -o sorted.bam
the result is:

Usage: samtools sort [options] <in.bam> <out.prefix>
Could you help me to fix the syntax?
Thanks a lot!
Best,
J

@marcelm
Copy link
Collaborator

marcelm commented Sep 26, 2024

You’re probably using a (very) old samtools version. I strongly recommend that you update, but in the meantime, I think you need to use both samtools view and samtools sort like this:

strobealign -t 60 01.H1.fasta H1.current_1.gz H1.current_2.gz | samtools view -Sb - | samtools sort -f - sorted.bam

Note that the current release of strobealign will likely not be able to use all 60 provided threads; this has only recently been fixed in the development version.

@jtamames
Copy link
Author

Thanks for the answer! I thougth it was using the samtools in your conda distro, but it is using the one in my system instead, that probably is rather old, indeed.
Best,
J

@marcelm
Copy link
Collaborator

marcelm commented Sep 26, 2024

Good point. Samtools isn’t listed as a dependency of the strobealign Conda package, so just running conda install strobealign will not install it. I’ll update the installation instructions.

@marcelm
Copy link
Collaborator

marcelm commented Sep 26, 2024

Note to whoever stumbles over this issue: I just noticed the command I suggested above won’t work. It’s better to upgrade.

@jtamames
Copy link
Author

Thank you Marcel.
Regarding this:

Note that the current release of strobealign will likely not be able to use all 60 provided threads; this has only recently been fixed in the development version.

which is the actual limit of threads that strobealign can manage?
Best,
J

@marcelm
Copy link
Collaborator

marcelm commented Sep 26, 2024

Quoting from the changelog of the unreleased version:

#269, #418: Strobealign scales now much better to systems with many cores. Previously, decompressing gzipped-compressed input files was a bottleneck starting at about 30 threads. We now use ISA-L for decompression, which is about three times as fast as zlib, and decompression is also done in a separate thread. We tested up to 128 cores, and strobealign was still able to use all cores. Contributed by @telmin.

@ksahlin What do you think about making a new release?

@ksahlin
Copy link
Owner

ksahlin commented Sep 26, 2024

A new release sounds good. Thanks Marcel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants