Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report (v0.8.0): Running FANSI with "weak harmonic regularisation + Linear + TGV" option #8

Closed
kschan0214 opened this issue Aug 3, 2020 · 0 comments

Comments

@kschan0214
Copy link
Owner

kschan0214 commented Aug 3, 2020

In SEPIA v0.8.0, we tried to fix a bug in the WH_wTGV.m of FANSI toolbox which will be used when the following options are selected:

  • Weak-Harmonic regularisation
  • Solver: Linear
  • Constraint: TGV

The bug occurs in line 122 of the original WH_wTGV.m:

Lap = E1+E1t+E2+E2t+E3+E3t;

where variables E1t, E2t and E3t are undefined before their usage.

To fix this we created a new function called WH_wTGV_4sepia.m and updated the line as

Lap = E1+Et1+E2+Et1+E3+Et2; %Lap = E1+E1t+E2+E2t+E3+E3t;

Upon checking, we found that the amendment is incorrect and we updated the line as

Lap = E1+Et1+E2+Et2+E3+Et3; %Lap = E1+E1t+E2+E2t+E3+E3t;

in the current master branch (commit 25c994, 3 August 2020).

The difference between the two versions is shown here:
Correction FANSI WH Linear TGV

If you are using SEPIA release v0.8.0 and want to use the above FANSI algorithm setting, please update SEPIA to the current master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant