Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of custom ClusterServingRuntimes breaks web app #46

Open
disrupted opened this issue Nov 7, 2022 · 0 comments
Open

Usage of custom ClusterServingRuntimes breaks web app #46

disrupted opened this issue Nov 7, 2022 · 0 comments

Comments

@disrupted
Copy link
Contributor

In our use case, we have some custom ClusterServingRuntimes in addition to the default ones KServe 0.8 ships with. It seems that this breaks the listing of all InferenceServices, regardless whether they actually use ServingRuntimes.

We’ve temporarily fixed this issue for us in a fork. https://github.com/bakdata/models-web-app/
Responsible was this check

if (Object.values(PredictorType).includes(predictor.model?.modelFormat.name as PredictorType)) {
which only accepts default KServe ServingRuntimes. With this change, the models-web-app correctly lists the InferenceServices again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant