-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory Termination Support #474
Comments
Hey, thanks so much for your commitment to improving KSCrash! Integrating memory termination support directly into the library sounds like a fantastic idea. I know a lot of teams have been using the algorithm from that Facebook article to handle OOMs on their own, so having this built into KSCrash could be super beneficial for everyone. @bamx23 what do you think? |
Wow, thanks! Yes, definitely worth bringing to KSCrash. OOMs are one of the most tricky types of crashes so any work towards making them easier to detect is a great work! @naftaly feel free to create a PR to v2.0 branch and we can discuss the implementation there. Or if you want we can start with overall concept of the implementation here in this issue. |
@bamx23 There are some great comments here and here in my Crashlytics PR that can help give an idea of how it works. I'll put a diff in the next days. |
@bamx23 @GLinnik21 I've put some work into this over the lats few days. Have a look at this branch in my fork and when you have a chance and tell me what you think. It's not totally done but the idea is there. |
Not OOM related... One thing that could make the system even more robust is "install folders". Basically, for each install there is a place on disk where things go which is different from the previous session (using GUIDs or something). This allows for a few things:
|
Hey, awesome work on this! I've gone through the code on your branch and it's looking solid. I do have a couple of minor questions, but we can get into those details once you draft the PR. Could you go ahead and create the PR targeting the |
PR Draft: #476 |
Is there any interest in integrating memory termination support directly into KSCrash, or is this something we want to leave up to those who integrate KSCrash?
Here's what I've done for Sentry, I'd love to bring this into KSCrash so a lot more teams get to process OOMs more efficiently.
The text was updated successfully, but these errors were encountered: