Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the recent test failure #107

Closed
Abirdcfly opened this issue Feb 14, 2023 · 1 comment
Closed

About the recent test failure #107

Abirdcfly opened this issue Feb 14, 2023 · 1 comment
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@Abirdcfly
Copy link
Member

Abirdcfly commented Feb 14, 2023

CleanShot 2023-02-14 at 13 37 47

A recent change in linter gci of golangci-lint believes that the previous code is wrong, as specified in daixiang0/gci#135.

Fixes daixiang0/gci#136 fix the general issue. our issue will continue to error. So just temporarily disable gci until a fix is found.

Fixes daixiang0/gci#136 to this issue have been merged.

A new version https://github.com/daixiang0/gci/releases/tag/v0.9.1 containing this issue has been released.

The upstream update pr golangci/golangci-lint#3576 of golangci-lint has also been merged.

However, the new version containing this pr has not been released (the latest version of golangci-lint https://github.com/golangci/golangci-lint/releases/tag/v1.51.1 was released before merging this code)

We can wait for golangci-lint to release a new version to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant