Add generic helpers to kube-core

[clux]

Lots of use cases for adding helpers when dealing with common interfaces like:

• finalizers Finalizer helper #291
• conditions Condition creation & management helpers #427
• annotations
• timestamps
• PartialObjectMetaExt - Genericize PartialObjectMeta over the underlying Resource #1152
• ownerrefs - Resource::controller_owner_ref can be plumbed into a Resource::owner_references_mut
• ObjectMetaExt or similar trait for stuff like https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/controller/controllerutil ?
• CustomResourceExt define a CustomResourceExt in kube for kube-derive #497
• CustomResourceDefinitionExt ? if there are more things like this
• ResourceExtChange Resource trait #486

This issue is an umbrella issue to cross-link utils, plus a place to discuss a possible feature'd module in kube, or a kube-utils crate.

[MatteoJoliveau]

Hi @clux, reviving this old issue to inquire regarding its status, specifically about helpers for owner refs.

I've been porting a subset of controllerutils to Rust to implement functions like set_controller_reference and set_owner_reference in a project and would love to donate the code to kube-rs. Would you be interested in a PR?

[clux]

Yeah, helpers like that would be very much appreciated! I think we have some logic like this already inside the finalizer helper that is utilizing jsonpatches. I personally always wanted that stuff to be a bit easier, at least for standard stuff, so implementations / sketches / ideas here here would be welcome.

Thinking this stuff would probably live in the core crate (if it's using jsonpatch), and then re-used down the line (e.g. the finalizer helper). If it's in core i am sure it would attract a bit of bikeshedding though :D

[MatteoJoliveau]

My helpers do not interact with any API by themselves. They're a straight port of controllerutil and only modify the Resource.

For instance here is the signature for set_controller_reference

fn set_controller_reference<O: Resource, K: Resource>(owner: &O, controlled: &mut K,) -> Result<(), AlreadyOwnedError>

[clux]

Ah, that type of module would also probably work inside core, not what I expected, but it's probably easier than combining json patches, and it's a clever signature.

[nightkr]

Yeah.. I think finalizers are a kind of special case, since they have "fun" timing requirements (the finalizer MUST be acknowledged by K8s BEFORE we start performing work that they'd clean up, and so on). Most should be fine to just integrate with the regular batching.

[johanfleury]

It would be nice to have ports of controllerutil.ContainsFinalizer(obj, finalizerName) and controllerutil.AddFinalizer(obj, finalizerName).