Disable Grafana by Default

[teevans]

Following up here on an email thread with AjayTripathy and nealormsbee.

Sounds like we're ready to make the switch to remove our shipped version of grafana by default.

AjayTripathy / nealormsbee

• What are the steps to get this done?

gz#2222

(related to Zendesk ticket #2222)

┆Issue is synchronized with this Jira Task by Unito

[nealormsbee]

@teevans I'll read through the Helm chart again to see if there are other considerations. Nominally, defaulting grafana.enabled = false in values.yaml.

That might be it, but there may be a little more. Broadcasting this change to users would also be good.

[dwbrown2]

@AjayTripathy can you share the broader gameplan here so we have context?

[AjayTripathy]

Note on implementation is you need to also set proxy=false

Here's my thoughts on broader plan. We should announce in patch notes that we're setting this to off but will continue to support byo grafana and community dashboards. Then over the next few releases we should remove grafana entirely from our app and only support byo+an integration with our dashboards.

[LaikaN57]

Config snippet from a mostly disabled grafana (for whatever it is worth in this discussion):

# Configure how we interface with Grafana - we aren't running it ourselves in
# this stack, but instead we're leveraging the one in the observability
# platform.
grafana:
  # -- Create datasources in the [REDACTED] namespace
  namespace_datasources: [REDACTED]
  datasources:
    # -- No need to connect the datasources - its already setup to connect to Prometheus
    enabled: false
  sidecar:
    dashboards:
      enabled: false
    datasources:
      defaultDatasourceEnabled: false
global:
  # https://github.com/kubecost/docs/blob/master/custom-prom.md#custom-grafana
  #
  # Undocumented, but both "enabled" and "proxy" must be false in combination.
  grafana:
    # -- Disable management of our own internal Grafana service
    enabled: false
    # -- Disable creating the /grafana proxy url in the kubecost nginx
    # config, it must be disabled to tell Kubecost to use the grafanaURL we
    # give it.
    proxy: false

[dwbrown2]

Thanks for sharing @LaikaN57!

@AjayTripathy I still think this needs a little more thought from a product perspective. I doubt most users will go install all dashboards unless they are easily bundled.

[AjayTripathy]

I'm supportive of continuing to bundle here-- I think this is just a question of turning grafana off by default? Set it to true and you'll still get the whole bundle. Open to additional feedback on that plan though!

[nickolashkraus]

As a side note, when disabling Grafana (global.grafana.enabled=false) if global.grafana.proxy=true, which is the default, the cost-analyzer-frontend Pod will crashloop:

nginx: [emerg] host not found in upstream "cost-analyzer-grafana.default.svc" in /etc/nginx/conf.d/default.conf:45

As @AjayTripathy stated, you need to set proxy=false.

[github-actions]

This issue has been marked as stale because it has been open for 360 days with no activity. Please remove the stale label or comment or this issue will be closed in 5 days.

[github-actions]

This issue was closed because it has been inactive for 365 days with no activity.