Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design for NAS model constructor #1127

Open
andreyvelich opened this issue Apr 7, 2020 · 4 comments
Open

Design for NAS model constructor #1127

andreyvelich opened this issue Apr 7, 2020 · 4 comments

Comments

@andreyvelich
Copy link
Member

/kind feature

Currently, for ENAS we have model constructor inside training container. I think, we can create Model somewhere else. In that case, user doesn't need to create model constructor inside training container.

Few thoughts:

  1. As @gaocegege mentioned here: [discussion] Support Advanced NAS Algorithms #461, we can use ONNX representation and create mode inside Suggestion. In that case, we can extend GetSuggestionsReply with additional field: bytes onnx_model. Or convert bytes to string, if it is possible.

  2. We can use JSON representation for the model (https://www.tensorflow.org/guide/keras/save_and_serialize#architecture-only_saving), but it will not save the weights. For enas it doesn't matter, but for other algorithms, maybe, we have to send model to Trials with predefined weights.

  3. I think we should create model inside Suggestion, since Trial is just a training job. For NAS algorithms user wants to receive the model in the training job. Also, for example darts algorithm mades some modifications with current running model during the training.

/cc @johnugeorge @gaocegege

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 0.72

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@jlewi jlewi removed the feature label Apr 7, 2020
@andreyvelich
Copy link
Member Author

/area nas

@stale
Copy link

stale bot commented Nov 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member Author

/lifecycle frozen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants