Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trial Pod's ownership to inject metrics collector sidecar container #1271

Closed
andreyvelich opened this issue Jul 16, 2020 · 2 comments · Fixed by #1303
Closed

Trial Pod's ownership to inject metrics collector sidecar container #1271

andreyvelich opened this issue Jul 16, 2020 · 2 comments · Fixed by #1303

Comments

@andreyvelich
Copy link
Member

/kind bug

See comment: #1261 (comment).

Currently, we compare pod's ownership name with Trial name and inject metrics collector sidecar if names are equal.
Name equality is not required condition when Trial owns the Pod.

We should check all sequence of Pod's ownership and see if Katib Trial resource is there.

/cc @gaocegege @johnugeorge

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/katib 0.70

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/front-end 0.65

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants