Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency google.golang.org/protobuf/testing/protocmp #2389

Closed
Electronic-Waste opened this issue Jul 17, 2024 · 1 comment · Fixed by #2391
Closed

Remove dependency google.golang.org/protobuf/testing/protocmp #2389

Electronic-Waste opened this issue Jul 17, 2024 · 1 comment · Fixed by #2391

Comments

@Electronic-Waste
Copy link
Member

Electronic-Waste commented Jul 17, 2024

What you would like to be added?

We will remove a package dependency protocmp from google.golang.org/protobuf/testing/protocmp in unit test files.

Why is this needed?

From Slack:

@Shao Wang Do you think, you have time to remove protocmp from this unit test as well so we can completely remove this dependancy from Katib: https://github.com/kubeflow/katib/blob/d2b0c4852bce239c4655e01520540aaee9e221ad/pk[…]tor/v1beta1/file-metricscollector/file-metricscollector_test.go ?

Love this feature?

Give it a 👍 We prioritize the features with most 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant