Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify studyjob json tag #351

Closed
hougangliu opened this issue Jan 30, 2019 · 2 comments
Closed

unify studyjob json tag #351

hougangliu opened this issue Jan 30, 2019 · 2 comments

Comments

@hougangliu
Copy link
Member

studyjob json tag should keep unified style, but now camelcase and lowercase mix as below, which leads to bad UE when a user write a studyjob yaml/json file. I suggest to keep camelcase.

type StudyJobSpec struct {
	StudyName            string                `json:"studyName,omitempty"`
	Owner                string                `json:"owner,omitempty"`
	OptimizationType     OptimizationType      `json:"optimizationtype,omitempty"`
	OptimizationGoal     *float64              `json:"optimizationgoal,omitempty"`
	ObjectiveValueName   string                `json:"objectivevaluename,omitempty"`
	RequestCount         int                   `json:"requestcount,omitempty"`
	MetricsNames         []string              `json:"metricsnames,omitempty"`
	ParameterConfigs     []ParameterConfig     `json:"parameterconfigs,omitempty"`
	WorkerSpec           *WorkerSpec           `json:"workerSpec,omitempty"`
	SuggestionSpec       *SuggestionSpec       `json:"suggestionSpec,omitempty"`
	EarlyStoppingSpec    *EarlyStoppingSpec    `json:"earlyStoppingSpec,omitempty"`
	MetricsCollectorSpec *MetricsCollectorSpec `json:"metricsCollectorSpec,omitempty"`
	NasConfig            *NasConfig            `json:"nasConfig,omitempty"`
}
@hougangliu hougangliu changed the title refactor studyjob json tag unify studyjob json tag Jan 30, 2019
@xyhuang
Copy link
Member

xyhuang commented Feb 5, 2019

/assign

@jlewi
Copy link
Contributor

jlewi commented Mar 10, 2019

It looks like this is fixed by #367.

@jlewi jlewi closed this as completed Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants