Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fine grained docker image build #580

Closed
gyliu513 opened this issue May 24, 2019 · 3 comments · Fixed by #605
Closed

Fine grained docker image build #580

gyliu513 opened this issue May 24, 2019 · 3 comments · Fixed by #605
Assignees
@gyliu513
Labels
kind/bug

Comments

@gyliu513
Copy link
Member

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

We are now using https://github.com/kubeflow/katib/blob/master/scripts/v1alpha2/build.sh to build all of the katib images at one time, it is better to update makefile by introducing fine grained docker image build. Like I can use make katib-controller to build katib controller etc, this can facilitate the development process, as I do not need to build all images every-time.

/cc @hougangliu @gaocegege @richardsliu
@gaocegege
Copy link
Member

SGTM

@gaocegege
Copy link
Member

@gyliu513 Can you help us on the issue?

@gyliu513
Copy link
Member Author

gyliu513 commented May 28, 2019 •
edited
Loading

/assign

@gaocegege Will try to fix this early next week.

@gyliu513 gyliu513 mentioned this issue May 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gyliu513 gyliu513

Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fine-grained docker image build. gyliu513/katib
3 participants
@gyliu513 @gaocegege @k8s-ci-robot