Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated build #77

Closed
YujiOshima opened this issue May 6, 2018 · 10 comments
Closed

Automated build #77

YujiOshima opened this issue May 6, 2018 · 10 comments

Comments

@YujiOshima
Copy link
Contributor

@gaocegege @jlewi
Who is the owner of the kubeflow docker hub repos?
Can you setup dockerhub's Automated Build for Katib images?

@gaocegege
Copy link
Member

I think Jeremy is the owner, and I have no permission to do it.

@jlewi
Copy link
Contributor

jlewi commented May 6, 2018

There is ongoing work to get DockerHub setup kubeflow/kubeflow#211.

More importantly there is an open issue kubeflow/kubeflow#666 to get a nightly build process setup for our Docker images.

My current thinking is that we should use Kaniko to build docker images within cluster and use a cron job or ArgoCd to trigger these regularly.

@YujiOshima any chance you'd be willing to experiment with building your images on K8s cluster using Kaniko?

We could also use prow post-submit jobs to push our Docker images to ci registry.

@YujiOshima
Copy link
Contributor Author

@jlewi OK! I will try to build our images with Kaniko.

@gaocegege
Copy link
Member

It seems that Kaniko does not support multiple stage build.

I see, let's skip Katib for now, will wait kaniko support multi stage or we find better tool

@gaocegege
Copy link
Member

But we definitely need CD for CLI and the docker images. There are some issues about it

Ref #80

@YujiOshima
Copy link
Contributor Author

Hmm, without multi-stage build, the image size will be so large.
But CD build is a high priority since we will probably cause an inconvenience for users.

  • Use Kaniko without muti-stage build for now. We wait it will be supported by Kaniko.
  • Use another tool (e.g. docker-hub automated build) until muti-stage build is supported by Kaniko.

IMHO, we can use kaniko without muti-stage build for now.
WDYT? @gaocegege @jlewi

@gaocegege
Copy link
Member

Ref GoogleContainerTools/kaniko#175

It works for me, but I think we should ask the kaniko owner if they want to implement the feature in the future.

@gaocegege
Copy link
Member

GoogleContainerTools/kaniko#141

It seems that they are working on it these days.

@YujiOshima
Copy link
Contributor Author

@jlewi @gaocegege
I have some troubles to use kaniko for building images.

  • How to send the katib source to kaniko worker(nfsPVC? or GCS?)
  • How to send the credentials to kaniko?

But now automated build and release process is the high priority since many user's issues are related to version mismatch.
So I want to use gcloud tool or docker command for now.
Then, which registry should I push to and how to use their credentials?
Would you help me?

@jlewi
Copy link
Contributor

jlewi commented Jun 5, 2018

Sorry for the slow reply.

We have some instructions here:
https://github.com/kubeflow/kubeflow/blob/master/docs_dev/releasing.md

You should define an Argo workflow to build your images using docker in docker. You can then follow the instructions on that page to add it to our nightly builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants