Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrapper e2e test with istio #2451

Merged
merged 4 commits into from
Feb 15, 2019
Merged

Conversation

lluunn
Copy link
Contributor

@lluunn lluunn commented Feb 11, 2019

/cc @kunmingg

/hold
needs #2450


This change is Reviewable

@lluunn
Copy link
Contributor Author

lluunn commented Feb 11, 2019

/retest

@lluunn
Copy link
Contributor Author

lluunn commented Feb 11, 2019

prow seems to have an issue

@lluunn
Copy link
Contributor Author

lluunn commented Feb 12, 2019

/hold cancel

@lluunn
Copy link
Contributor Author

lluunn commented Feb 12, 2019

/hold

@lluunn
Copy link
Contributor Author

lluunn commented Feb 12, 2019

waiting for #2462

@lluunn
Copy link
Contributor Author

lluunn commented Feb 13, 2019

/hold cancel

@kunmingg
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 62547c0 into kubeflow:master Feb 15, 2019
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* enable istio e2e test

* fix

* fix
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 12, 2021
* enable istio e2e test

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants