Update tf jupter notebook images to include tfma (from #544) #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't TFMA require newer versions of TF? Should we not install the package in images corresponding to unsupported versions of TF? |
|
They only mention 1.6 So I suggest not installing it in images with TF versions older than 1.6 |
|
Updated PR to only update tf1.6 and tf1.7 |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal, ojarjur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
pushed a commit
that referenced
this pull request
Apr 3, 2018
* Update tf jupter notebook images to include tfma (from #544) (#570) * Update tf jupter notebook images to include tfma (from #544) tf1.4 gpu image has issues building with the latest tfma, so that's not updated in this PR /cc @jlewi /cc @ojarjur * Don't update tf images older than 1.6 * Moved OAuth secret from param to named secret (#572)
swiftdiaries
pushed a commit
to swiftdiaries/kubeflow
that referenced
this pull request
Apr 4, 2018
…ubeflow#570) * Update tf jupter notebook images to include tfma (from kubeflow#544) tf1.4 gpu image has issues building with the latest tfma, so that's not updated in this PR /cc @jlewi /cc @ojarjur * Don't update tf images older than 1.6
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Nov 1, 2019
…ted by registration. (kubeflow#570) * kubeflow#4281
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
…ubeflow#570) * Update tf jupter notebook images to include tfma (from kubeflow#544) tf1.4 gpu image has issues building with the latest tfma, so that's not updated in this PR /cc @jlewi /cc @ojarjur * Don't update tf images older than 1.6
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Feb 15, 2021
* WIP Signed-off-by: Ce Gao <gaoce@caicloud.io> * fix: Fix test cases Signed-off-by: Ce Gao <gaoce@caicloud.io>
elenzio9
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf1.4 gpu image has issues building with the latest tfma, so that's
not updated in this PR. Related : #571
Also add tf1.7 images
/cc @jlewi
/cc @ojarjur
This change is