-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ksonnet changes to support deploying the v1alpha2 TFJob operator. #851
Conversation
* K8s doesn't support installing multiple versions of a CRD in the same cluster. * So we add an option to choose which version to support. * We don't add an E2E test in this PR because its not straightforward. Currently the E2E test deploys Kubeflow in a different namespace but not a different cluster. This won't allow us to simulatenously test both versions. * So to test multiple versions we will need to spin up a separate GKE cluster. Related to: kubeflow#599
/assign @gaocegege |
@gaocegege PTAL |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Test failure looks like some random networking issue
|
/retest |
…beflow#851) * ksonnet changes to support deploying the v1alpha2 TFJob operator. * K8s doesn't support installing multiple versions of a CRD in the same cluster. * So we add an option to choose which version to support. * We don't add an E2E test in this PR because its not straightforward. Currently the E2E test deploys Kubeflow in a different namespace but not a different cluster. This won't allow us to simulatenously test both versions. * So to test multiple versions we will need to spin up a separate GKE cluster. Related to: kubeflow#599 * Autoformat jsonnet.
* chore: Speedup local build.sh Signed-off-by: Ce Gao <gaoce@caicloud.io> * chore: Update liveness probe Signed-off-by: Ce Gao <gaoce@caicloud.io> * chore: Ignore frontend build Signed-off-by: Ce Gao <gaoce@caicloud.io>
K8s doesn't support installing multiple versions of a CRD in the same cluster.
So we add an option to choose which version to support.
We don't add an E2E test in this PR because its not straightforward.
Currently the E2E test deploys Kubeflow in a different namespace but not
a different cluster. This won't allow us to simulatenously test both
versions.
So to test multiple versions we will need to spin up a separate GKE cluster.
Related to: kubeflow/training-operator#599
This change is