Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubeflow 1.6 Dependency Versions #2207

Closed
annajung opened this issue May 10, 2022 · 20 comments
Closed

Kubeflow 1.6 Dependency Versions #2207

annajung opened this issue May 10, 2022 · 20 comments

Comments

@annajung
Copy link
Member

annajung commented May 10, 2022

Based on the initial input gathered from different WGs and release team discussions, Kubeflow 1.6 will aim to support the following dependency versions.

  • Kubernetes 1.22
  • Istio 1.14.1
  • Knative 1.2
  • Cert Manager v1.5.0
  • Dex v2.31.2

While different Kubernetes versions may be tested, our primary goal for the release is to focus our efforts on Kubernetes version 1.22.

If you have any concerns or like to propose a different version, please leave a comment here to allow transparency across all WG leads.

@kubeflow/wg-automl-leads @kubeflow/wg-manifests-leads @kubeflow/wg-training-leads @kubeflow/wg-pipeline-leads @kubeflow/wg-notebooks-leads @pvaneck @yuzisun @zijianjoy @kubeflow/release-team

For additional context, below are the versions supported in the previous Kubeflow 1.5 release

  • Kubernetes 1.21, 1.20, 1.19
  • Istio 1.11
  • Knative 0.22.1
  • Cert Manager v1.5.0
  • Dex v2.22.0
@jbottum
Copy link

jbottum commented May 10, 2022

@annajung we might want to track the Kustomize version too. i.e. will it be 3.2 or 4.x

@annajung
Copy link
Member Author

Based on the discussion from the May 10th community meeting, @yhwang raised concerns with the Knative version proposed here and shared Kserve's need to have at least Knative 1.0+

With Knative being used only by the Kserve WG, the release team plans to work with KServe team to figure out which version needs to be supported for the 1.6 release and update the proposal based on their feedback

cc @mstopa @pvaneck @yuzisun

@johnugeorge
Copy link
Member

Ref: kubeflow/katib#1828

Are we planning to use networking.istio.io/v1alpha3 or networking.istio.io/v1beta1 for VirtualService in 1.6 release ?

/cc @tenzen-y

@pvaneck
Copy link
Member

pvaneck commented Jun 22, 2022

We have decided to go with Knative 1.4 as the desired version of Knative for KF 1.6. I can help with with the initial PR updating the manifests.

@kimwnasptd
Copy link
Member

Are we planning to use networking.istio.io/v1alpha3 or networking.istio.io/v1beta1 for VirtualService in 1.6 release?

@johnugeorge, @dpoulopoulos and I were testing the Istio 1.14 manifests with the whole Kubeflow without issues and using v1alpha3. To my best knowledge there shouldn't be an issue with v1alpha3 so I'd suggest to keep the current version for the first RC.

If later on we bump into issues with v1alpha3 we can include fixes in the release branches.

@annajung
Copy link
Member Author

Hi @kimwnasptd could you also update us on the Istio version. During the release team meeting on June 27th, you mentioned that 1.13 is near EOL support which was a concern for using 1.13 for KF 1.6 release. Based on your comment above, has Manifest WG decided to use Istio 1.14 instead of 1.13 for KF 1.6?

@kimwnasptd
Copy link
Member

@annajung @kubeflow/release-team, @dpoulopoulos and I have been testing Istio 1.14 until this point without seeing any issues.

We decided to go with Istio 1.13 instead of 1.14 since 1.13 will be EOL by October https://istio.io/latest/docs/releases/supported-releases/#support-status-of-istio-releases. The upgrade notes from 1.13 to 1.14 are also minimal so we are confident we won't bump into any issues https://istio.io/latest/news/releases/1.14.x/announcing-1.14/upgrade-notes/.

But we'll be keeping a close eye for any issues that might arise throughout the WGs during the feature freeze.

@kimwnasptd
Copy link
Member

We have decided to go with Knative 1.4 as the desired version of Knative for KF 1.6. I can help with with the initial PR updating the manifests.

@pvaneck if you'd have some cycles to follow the instructions and update Knative that would be a huge help! If not I'll try to push for a PR early tomorrow for this one as well.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Jun 29, 2022

We have decided to go with Knative 1.4 as the desired version of Knative for KF 1.6. I can help with with the initial PR updating the manifests.

@pvaneck if you'd have some cycles to follow the instructions and update Knative that would be a huge help! If not I'll try to push for a PR early tomorrow for this one as well.

it would be amazing if you could use tags instead of digests for the new knative images. Currently it is a mixture of both.

@annajung
Copy link
Member Author

annajung commented Jul 7, 2022

@annajung
Copy link
Member Author

Update Knative 1.4 to 1.2: #2251

@mnmami
Copy link

mnmami commented Aug 1, 2022

@annajung will Kubeflow 1.6 keep support for Kubernetes versions 1.20 and 1.21?

@annajung
Copy link
Member Author

annajung commented Sep 8, 2022

Hi @mnmami sorry for the late reply! The release team has been working closely with manifest WG, who have been focused on testing against only the 1.22 k8s cluster. Therefore, we don't officially support 1.21 or 1.20 with the 1.6 release.

@mnmami
Copy link

mnmami commented Sep 9, 2022

@annajung thanks for clarifying. This information is very important for organizations to plan and manage their upgrade strategy for Kubeflow both on-prem and in the cloud.

@umka1332
Copy link

It would be very nice to update Seldon that is delivered with Kubeflow to support K8s 1.22+.

@sylus
Copy link

sylus commented Sep 21, 2022

@kimwnasptd where can i find the instructions on how to upgrade knative properly from the previous CRDs

Just pointing to the new manifests isn't enough since the upgrade steps need to be performed and I thought kubeflow would offer these instructions in a centralized place even if just pointing to the knative upgrade steps which I think is just follow the release notes.

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- github.com/kubeflow/manifests/common/knative/knative-serving/base?ref=v1.6.0
- github.com/kubeflow/manifests/common/knative/knative-eventing/base?ref=v1.6.0

@sylus
Copy link

sylus commented Sep 21, 2022

Also the release blog for KF v1.6 claims that every component has been tested for 1.22?

https://blog.kubeflow.org/kubeflow-1.6-release/

However for spark the CRD calling v1beta1

https://github.com/kubeflow/manifests/blob/master/contrib/spark/spark-operator/base/sparkapplications.sparkoperator.k8s.io-crd.yaml#L1

I think Spark and Seldon aren't considering core components since I don't see them in testing suite:

https://github.com/kubeflow/manifests/pull/2230/files

@sylus
Copy link

sylus commented Sep 23, 2022

This is what I needed to do to update knative:

 krm mutatingwebhookconfigurations.admissionregistration.k8s.io webhook.serving.knative.dev
 krm validatingwebhookconfigurations.admissionregistration.k8s.io validation.webhook.serving.knative.dev
 kubectl create -f ../../../serving-storage-version-migration.yaml (v0.18.3)
 kubectl create -f ../../../eventing-post-install.yaml (v0.23.0)
 // wait for job to finish
 kubectl delete -f ../../../eventing-post-install.yaml
 kubectl create -f ../../../eventing-post-install.yaml (v1.2.4)
 // wait for job to finish
 // re-sync ArgoCD

With this I was able to deploy Kubeflow on Azure AKS from v1.4.1 -> 1.6.0 via ArgoCD and everything seems to be working / sync'd except for seldon and spark.

@annajung
Copy link
Member Author

Hi @umka1332 and @sylus, could you create a separate issue for Seldon and spark to be tracked outside of this issue? This issue was created to determine the core dependency versions for the 1.6 release. With the 1.6 release out, I'm closing this as it's been completed.

@umka1332
Copy link

umka1332 commented Sep 28, 2022

Hi @umka1332 and @sylus, could you create a separate issue for Seldon and spark to be tracked outside of this issue? This issue was created to determine the core dependency versions for the 1.6 release. With the 1.6 release out, I'm closing this as it's been completed.

Done for Seldon - #2290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants