Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpi job bug #2334

Open
fyxemmmm opened this issue Nov 25, 2024 · 3 comments
Open

mpi job bug #2334

fyxemmmm opened this issue Nov 25, 2024 · 3 comments
Labels
kind/bug lifecycle/needs-triage

Comments

@fyxemmmm
Copy link

fyxemmmm commented Nov 25, 2024 •
edited
Loading

What happened?

v1.8.1 version

training-operator/pkg/controller.v1/mpi/mpijob_controller.go -> UpdateJobStatus

when job failed,
The judgment if spec.RestartPolicy == commonv1.RestartPolicyExitCode seems to be problematic. It should be if spec.RestartPolicy != commonv1.RestartPolicyNever...
@andreyvelich
Copy link
Member

cc @tenzen-y @alculquicondor @terrytangyuan

@terrytangyuan
Copy link
Member

Would you mind sending a PR so that we can review what exact code you are referring to?

@fyxemmmm
Copy link
Author

fyxemmmm commented Dec 5, 2024

#2344 @terrytangyuan here is the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug lifecycle/needs-triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@terrytangyuan @andreyvelich @fyxemmmm