Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark transitive dependencies optional #3768

Open
cowwoc opened this issue Oct 25, 2024 · 1 comment
Open

Mark transitive dependencies optional #3768

cowwoc opened this issue Oct 25, 2024 · 1 comment

Comments

@cowwoc
Copy link

cowwoc commented Oct 25, 2024

Describe the bug
client-java depends on io.prometheus:* and com.com.amazonaws:*. Both dependencies pull in needless transitive dependencies for users who don't use prometheus or aws.

Client Version
21.0.1

Expected behavior
Review all dependencies as mark as many as possible as optional. See https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html for more information.

@cowwoc cowwoc changed the title Mark some transitive dependencies optional Mark transitive dependencies optional Oct 25, 2024
@brendandburns
Copy link
Contributor

Happy to take PRs to improve/add the right optional dependencies for libraries related to auth.

Removing prometheus may be trickier, but again, open to reviewing PRs

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants