This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
bootkube/pkg/recovery/recover fix hostNetwork #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
k8s-ci-robot
added
cncf-cla: yes
|
ok to test |
diegs
suggested changes
Feb 22, 2018
| @@ -186,6 +186,7 @@ func TestFixUpBootstrapPods(t *testing.T) { | |||
| ReadOnly: true, | |||
| }}, | |||
| }}, | |||
| HostNetwork: true, | |||
There was a problem hiding this comment.
Should actually not set these in the pods array--the fixUpBootstrapPods method should add them.
k8s-ci-robot
added
size/M
|
coreosbot run e2e calico |
Fixes: kubernetes-retired#902 Adds hostNetwork: true to all generated assets and tests for same.
coresolve
force-pushed
the
fix_hostnet
branch
from
5122a8e
to
506f4fb
Compare
rphillips
approved these changes
Feb 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #902
Adds hostNetwork: true to all generated assets and tests for same.