From a57ad940fd573860f8e9ad341a6eb0e81e3f8de8 Mon Sep 17 00:00:00 2001 From: "Lubomir I. Ivanov" Date: Sat, 22 Jun 2019 22:34:20 +0300 Subject: [PATCH] README: modify the build step for binaries '-o' for directories is still bleeding edge and has some bugs in 1.12. See issue 14295 in https://github.com/golang/go. - Inline separate build commands for the binaries. - Include GO111MODULE=on as it's required if the repo was cloned in GOPATH - Include the binaries in .gitignore --- .gitignore | 3 +++ README.md | 12 +++++++++--- 2 files changed, 12 insertions(+), 3 deletions(-) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..e1b6172 --- /dev/null +++ b/.gitignore @@ -0,0 +1,3 @@ +capdctl +capd-manager +kind-test diff --git a/README.md b/README.md index 2add12a..278b672 100644 --- a/README.md +++ b/README.md @@ -6,10 +6,16 @@ A sample is built and hosted at `gcr.io/kubernetes1-226021/capd-manager:latest` ### Building the binaries -Requires go with go modules. +Requires go 1.12+ with go modules. -* `go build ./cmd/...` -* `go build ./cmd/` +``` +# required if `cluster-api-provider-docker` was cloned into $GOPATH +export GO111MODULE=on +# build the binaries +go build ./cmd/capdctl +go build ./cmd/capd-manager +go build ./cmd/kind-test +``` ### Building the image