-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Move ingress to a new repo #1441
Comments
I'd be happy to work on this this quarter. |
Maybe link up with @aledbf and write a rough plan? I can get Tim to open the repo. See disucssion on https://groups.google.com/forum/#!topic/kubernetes-dev/fSZcq9zkI-s The big pieces are probably:
We don't need to fix all of these before moving, we can simply lift and shift, but we should take this opportunity to think about how we're going to handle the issues. We also need at least an OWNERS and CONTRIBUTING.md |
@bprashanth I already have:
|
We need to agree on versioning (semver?) and what qualificatio one needs to perform before cutting a new release (if we have an e2e builder this will not matter as much). Also some guidelines for what to include in release notes. I'd agree with just running the basic nginx e2e (https://github.com/kubernetes/kubernetes/blob/master/test/e2e/ingress.go#L154) is a good starting block (not all on localhost, setup an actual kube-up cluster like most users will if possible), but ideally we'd find a way to test this on gce and aws as well (though those don't necessarily need to happen presubmit). |
Issues go stale after 30d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
I've been meaning to split ingress off into its own repo but haven't had time. All ingress controllers are already modular enough to run in their own containers, and already have Godeps in the contrib/ingress/_vendor directory.
Currently we get some tooling for free in contrib (persubmit verification, munging etc) that would be nice to continue to have. It would also be good to nail down a concrete release and test plan. The latter doesn't block going to a new repo, but if we don't do it now I fear we'll just never do it.
The release plan right now is: whenever we feel like, directly in contrib/releases, and the test plan right now is: e2e in main kubernetes repo. Ideally we should at least sketch out a proposal to run e2es with ingress ToT in addition to the e2es in main repo, just like we do for cadvisor.
#762
The text was updated successfully, but these errors were encountered: