Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

Add SupportsMountOption to Provisioner interface #828

Closed
wongma7 opened this issue Jun 22, 2018 · 8 comments
Closed

Add SupportsMountOption to Provisioner interface #828

wongma7 opened this issue Jun 22, 2018 · 8 comments
Assignees
Labels
area/lib lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@wongma7
Copy link
Contributor

wongma7 commented Jun 22, 2018

It makes sense to test it in the controller BEFORE we call provision. Many/all of the provisioners in this repo are out-of-date wrt how they treat mount options, this will be an opportunity to clean it up

@wongma7 wongma7 self-assigned this Jun 22, 2018
@wongma7
Copy link
Contributor Author

wongma7 commented Jun 22, 2018

see also #810

@wongma7
Copy link
Contributor Author

wongma7 commented Jun 22, 2018

It will default false with a nice error message.

@Kation
Copy link

Kation commented Sep 12, 2018

It seems not published with newest v3.1.0-k8s1.11?

@wongma7
Copy link
Contributor Author

wongma7 commented Sep 12, 2018

it should work, please share your class.mountOptions... the same mountOptions should appear on every PV

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 25, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/lib lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants