HNC: Migrate to v1 apis of CRDs, Mutating WH, and Admission WH (v1beta1 deprecation)

[rjbez17]

These APIs have moved to GA and the beta versions are now deprecated. They will be completed remove in kubernetes 1.22.

A quick search of the repo showed that we are using the v1beta1 apis in a few places. We also need to keep in mind that if we completely remove the usage of v1beta1 we change our supported versions to the version of kubernetes where v1 is introduced (1.16).

More info here: https://groups.google.com/g/kubernetes-sig-api-machinery/c/OmC8vB7oiGM/m/ZH3qv-0sDwAJ?pli=1

[adrianludwin]

We just updated to controller-runtime v0.7.0 which at least should fix the issue for the webhooks. I think we probably need to upgrade our version of controller-tools to generate the latest version of the CRD.

Are you still seeing the v1beta1 webhook APIs anywhere?

[adrianludwin]

Note that we're using controller-tools 0.2.8 but the latest release is 0.4.1. When we upgrade, we need to update our code to take advantage of kubernetes-sigs/controller-tools#468 (ensure we're using CRD v1).

[rjbez17]

The current default ca injector is one I saw: https://github.com/kubernetes-sigs/multi-tenancy/blob/925711745afed4e3f80c32a8ed6974964ff663a4/incubator/hnc/config/default/webhookcainjection_patch.yaml

Other than that it seems to just be CRDs.

[adrianludwin]

Ah good point. I'll bet that updating controller-tools would fix that too.