Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

HNC: Add webhook rules to deny editing namespace tree labels #1494

Closed
yiqigao217 opened this issue Apr 27, 2021 · 2 comments
Closed

HNC: Add webhook rules to deny editing namespace tree labels #1494

yiqigao217 opened this issue Apr 27, 2021 · 2 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Milestone
hnc-v0.9

Comments

@yiqigao217
Copy link
Contributor

Currently, the tree labels on namespaces can be edited without webhook blocking it. HNC will re-reconcile the namespace to update the tree labels.

We need to have our webhooks to block edits on namespace tree labels.
@yiqigao217 yiqigao217 added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Apr 27, 2021
@yiqigao217 yiqigao217 added this to the hnc-backlog milestone Apr 27, 2021
@yiqigao217 yiqigao217 mentioned this issue Apr 28, 2021
Closed
@adrianludwin adrianludwin modified the milestones: hnc-backlog, hnc-v0.9 Apr 29, 2021
@yiqigao217 yiqigao217 removed this from the hnc-v0.9 milestone May 5, 2021
@yiqigao217 yiqigao217 removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 5, 2021
@yiqigao217 yiqigao217 mentioned this issue May 5, 2021
Closed
@yiqigao217 yiqigao217 added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 5, 2021
@yiqigao217 yiqigao217 added this to the hnc-v0.9 milestone May 5, 2021
@yiqigao217 yiqigao217 mentioned this issue May 5, 2021
Closed
@adrianludwin
Copy link
Contributor

Replaced by kubernetes-sigs/hierarchical-namespaces#12

/close

@k8s-ci-robot
Copy link
Contributor

@adrianludwin: Closing this issue.

In response to this:

Replaced by kubernetes-sigs/hierarchical-namespaces#12

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Milestone
hnc-v0.9
Development

No branches or pull requests
3 participants
@k8s-ci-robot @adrianludwin @yiqigao217