Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Add a dashboardURL row to svcat describe instances #2257

Closed
robertscherbarth opened this issue Aug 3, 2018 · 2 comments
Closed

Add a dashboardURL row to svcat describe instances #2257

robertscherbarth opened this issue Aug 3, 2018 · 2 comments
Assignees

Comments

@robertscherbarth
Copy link
Contributor

Hi,

i want to offer the user of a service broker the possibility to get a monitoring url via svcat. Something like this:

  Name:            example-starter-pack-service
  Namespace:       test-ns
  Status:          ready
  DashboardURL:    grafana.example.com
  Class:           example-starter-pack-service
  Plan:            default

Parameters:
  param-1: value-1
  param-2: value-2

Bindings:
No bindings defined 

I have already codet it in a feature branch (https://github.com/robertscherbarth/service-catalog/tree/add-dashboard-url-svcat). I am not sure. Can i open an pull request without a issue?

@MHBauer
Copy link
Contributor

MHBauer commented Aug 3, 2018

Didn't look at the code.

A PR could be the way to go.

We've got the devguide for some details on contributing.

The biggest thing is probably the CLA if you haven't signed it.

/assign @carolynvs @jber

@k8s-ci-robot
Copy link
Contributor

@MHBauer: GitHub didn't allow me to assign the following users: jber.

Note that only kubernetes-incubator members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

Didn't look at the code.

A PR could be the way to go.

We've got the devguide for some details on contributing.

The biggest thing is probably the CLA if you haven't signed it.

/assign @carolynvs @jber

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants