Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ALB rules by the same host #2678

Open
michaelkoro opened this issue Jun 6, 2022 · 6 comments
Open

Merge ALB rules by the same host #2678

michaelkoro opened this issue Jun 6, 2022 · 6 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@michaelkoro
Copy link

Is your feature request related to a problem?
We would like to be able to merge rules in the ingress resource, on the ALB level.

For example, when creating the following -

spec:
  rules:
    - http:
        paths:
          - path: /test1
            pathType: ImplementationSpecific
            backend:
              service:
                name: service_name
                port:
                  number: 80
          - path: /test2
            pathType: ImplementationSpecific
            backend:
              service:
                name: service_name
                port:
                  number: 80
    - http:
        paths:
          - path: /*
            pathType: ImplementationSpecific
            backend:
              service:
                name: service_name
                port:
                  number: 80

We want the controller to merge the two paths in the first rule, and create one rule in the ALB.
We are aware of the conditions annotation, but unfortunately working with it dynamically is very complicated.
Is there an easier way?

@kishorj
Copy link
Collaborator

kishorj commented Aug 11, 2022

@michaelkoro, we can optimize in limited situations - for consecutive rules so as to honor the ingress group order. Also the current ALB limit is max 5 conditions per rule.

Are you hitting the rules quotas or have other concerns?

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 11, 2022
@kishorj kishorj added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Aug 11, 2022
@acgs771126
Copy link

+1, maybe this feature can prevent hit AWS ELB listener rule api throttle

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2023
@benjefferies
Copy link

+1 would be great to see this in v2.6.0

@omerap12
Copy link
Member

/assign

@henryzhao95
Copy link

+1, would love to see multiple hostnames with same backing service grouped together!

spec:
  ingressClassName: group1
  rules:
    - host: bar.api.internal
      http:
        paths:
        - pathType: Prefix
          path: "/"
          backend:
            service:
              name: awesome-service
              port:
                number: 443
    - host: foo.api.internal
      http:
        paths:
        - pathType: Prefix
          path: "/"
          backend:
            service:
              name: awesome-service
              port:
                number: 443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

8 participants