Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for Availability Zone Affinity #3470

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Adding support for Availability Zone Affinity #3470

merged 1 commit into from
Mar 19, 2024

Conversation

alex-berger
Copy link
Contributor

@alex-berger alex-berger commented Nov 3, 2023 •
edited
Loading

Issue

Fixes #3431

Description

Added support to set NLB attribute dns_record.client_routing_policy to configure Availability Zone DNS Affinity.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@alex-berger
Adding support for Availability Zone Affinity
85c43a7 
Fixes kubernetes-sigs#3431

Signed-off-by: Alex Berger <alex-berger@gmx.ch>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 3, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @alex-berger!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 3, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @alex-berger. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 3, 2023
@alex-berger alex-berger mentioned this pull request Nov 5, 2023
Closed
@oliviassss
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 18, 2024
@alex-berger
Copy link
Contributor Author

/retest

oliviassss
oliviassss requested changes Jan 24, 2024
View reviewed changes
pkg/service/model_build_load_balancer.go
partialAvailabilityZoneAffinity = "partial_availability_zone_affinity"
anyAvailabilityZone = "any_availability_zone"
resourceIDLoadBalancer = "LoadBalancer"
minimalAvailableIPAddressCount = int64(8)
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some test coverage on these attributes? https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/pkg/service/model_build_load_balancer_test.go#L28

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just constants for the possible values for attribute lbAttrsLoadBalancingDnsClientRoutingPolicy, for which I already added as tests in https://github.com/kubernetes-sigs/aws-load-balancer-controller/pull/3470/files#diff-5c328b7b0a8428bb53f5a7b561091d3df4bf46a76538ea0a1590611b584d1196R118.

	partialAvailabilityZoneAffinity          = "partial_availability_zone_affinity"
	anyAvailabilityZone                      = "any_availability_zone"
	resourceIDLoadBalancer                   = "LoadBalancer"

Sorry, but I don't get it what you expect me to do.

@oliviassss
Copy link
Collaborator

/retest

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@oliviassss
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2024
@oliviassss oliviassss added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 14, 2024
@shraddhabang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alex-berger, oliviassss, shraddhabang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8296620 into kubernetes-sigs:main Mar 19, 2024
4 checks passed
shraddhabang pushed a commit to shraddhabang/aws-load-balancer-controller that referenced this pull request Mar 20, 2024
@alex-berger @shraddhabang
Adding support for Availability Zone Affinity (kubernetes-sigs#3470)
c3762f9 
Fixes kubernetes-sigs#3431

Signed-off-by: Alex Berger <alex-berger@gmx.ch>
M00nF1sh pushed a commit that referenced this pull request Mar 22, 2024
@shraddhabang @oliviassss
@alebedev87 @the-technat @jukie @xdu31 @haouc @alex-berger
Release v2.7.2 - Cherry picked the commits from main (#3620)
61e0135 
* fix log level in listener manager and tagging manager (#3573)

* bump up controller-gen version and update manifests (#3580)

* docs: ingress subnets annotation - clarify locale differences (#3579)

* feat: allowed ACM cert discovery to filter on CA ARNs (#3565) (#3591)

* Add example for NLB target-group-attributes to enable unhealthy target connection draining (#3577)

* Add example annotation for NLB unhealthy target connection draining

* Add emtpyline back in

* fix: ca-filter causing expontentially more api-calls (#3608)

due to missing cache

* Repo controlled build go version (#3598)

* update go version to mitigate CVE (#3615)

* Adding support for Availability Zone Affinity (#3470)

Fixes #3431

Signed-off-by: Alex Berger <alex-berger@gmx.ch>

* Update golang.org/protobuf version to fix CVE-2024-24786 (#3618)

* Add a note to recommend to use compatible chart and image versions

* Update golang.org/protobuf version to fix CVE-2024-24786

---------

Signed-off-by: Alex Berger <alex-berger@gmx.ch>
Co-authored-by: Olivia Song <sonyingy@amazon.com>
Co-authored-by: Andrey Lebedev <alebedev87@gmail.com>
Co-authored-by: Nathanael Liechti <technat@technat.ch>
Co-authored-by: Isaac Wilson <10012479+jukie@users.noreply.github.com>
Co-authored-by: Nathanael Liechti <nathanael.liechti@post.ch>
Co-authored-by: Jason Du <jasonxdu@amazon.com>
Co-authored-by: Hao Zhou <haouc@users.noreply.github.com>
Co-authored-by: Alexander Berger <alex-berger@users.noreply.github.com>
@stevehipwell stevehipwell mentioned this pull request Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviassss oliviassss oliviassss approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@shraddhabang shraddhabang

@oliviassss oliviassss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zone DNS affinity
4 participants
@alex-berger @k8s-ci-robot @oliviassss @shraddhabang