Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release failed due to an issue with the ARM build #4835

Closed
richardcase opened this issue Feb 29, 2024 · 2 comments · Fixed by #4836
Closed

Release failed due to an issue with the ARM build #4835

richardcase opened this issue Feb 29, 2024 · 2 comments · Fixed by #4836
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@richardcase
Copy link
Member

/kind bug

What steps did you take and what happened:

When doing the v2.4.0 release we ran into an issue with the arm build of the controller-manager:

179.9 # github.com/openshift/rosa/pkg/ocm
179.9 /go/pkg/mod/github.com/openshift/rosa@v1.2.35-rc1.0.20240221134836-0beb882e5836/pkg/ocm/helpers.go:969:21: math.MaxInt64 (untyped int constant 9223372036854775807) overflows int

@damdo investigated and found this reference: golang/go#23086 and this might need to be changed as a result: https://github.com/openshift/rosa/blob/ded22540d1fe227ea0a13197c7a8136099be890e/pkg/ocm/helpers.go#L969C21-L969C34

This highlights that there is a gap in our pre-submit jobs that cover all the architectures we support.

What did you expect to happen:

Expect the release process to work.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 29, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo
Copy link
Member

damdo commented Feb 29, 2024

Reference for the ROSA fix: openshift/rosa#1810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants