Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPA-created subnet should have the "kubernetes.io/cluster/<clusterID>:" tag with "owned" value instead of "shared" #5050

Closed
r4f4 opened this issue Jul 12, 2024 · 1 comment · Fixed by #5051
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@r4f4
Copy link
Contributor

r4f4 commented Jul 12, 2024

/kind bug

What steps did you take and what happened:

Right now CAPA is applying the same "kubernetes.io/cluster/: shared" tag for subnets whether they are managed or unmanaged.

What did you expect to happen:

CAPA-created (managed) subnets should be tagged with "owned".

Anything else you would like to add:

The tag value itself shouldn't cause issues for CCM since it matches only on the tag Key: https://github.com/kubernetes/cloud-provider-aws/blob/master/pkg/providers/v1/aws.go#L1604-L1611

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 12, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants