Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect ASO resources/logs in e2e artifacts #3532

Closed
1 task done
Tracked by #3402
nojnhuh opened this issue May 4, 2023 · 3 comments · Fixed by #3723
Closed
1 task done
Tracked by #3402

Collect ASO resources/logs in e2e artifacts #3532

nojnhuh opened this issue May 4, 2023 · 3 comments · Fixed by #3723
Assignees
@nojnhuh
Milestone
v1.11

Comments

@nojnhuh
Copy link
Contributor

nojnhuh commented May 4, 2023 •
edited
Loading

Dependencies
Preview Give feedback
  1. Enable ASO #3527
    9 of 9
    nojnhuh
@nojnhuh nojnhuh mentioned this issue May 4, 2023
Closed
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 9, 2023

I've done some testing that shows these are already being collected, but I'm not sure how since the ASO components and CRDs don't get installed with the cluster.x-k8s.io/provider label like it seems the CAPI test framework uses as its trigger to collect.

I'll leave this issue open as a reminder to audit when we start running e2e tests with ASO in CI.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 21, 2023

e2e artifacts from #3723 show the ASO ResourceGroup and ASO controller logs, so I'll have #3723 also close this issue once it merges.

@nojnhuh nojnhuh mentioned this issue Jul 21, 2023
Merged
4 tasks
@nojnhuh nojnhuh added this to the v1.11 milestone Jul 27, 2023
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 14, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nojnhuh nojnhuh

Labels
None yet
Projects
CAPZ Planning
Archived in project
Milestone
v1.11
Development

Successfully merging a pull request may close this issue.

Enable ASO nojnhuh/cluster-api-provider-azure
1 participant
@nojnhuh