-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Manager: Start all caches before other Runnables #1327
✨ Manager: Start all caches before other Runnables #1327
Conversation
c9b52c6
to
8e59887
Compare
/retest |
This pr implements the second half of the ["Move cluster-specific code out of the manager" proposal][0]: Making it start all caches before other Runnables and not just the one of the main Cluster. [0]: https://github.com/kubernetes-sigs/controller-runtime/blob/66537ca5b7439b06f2f3b08901640f934834c9a1/designs/move-cluster-specific-code-out-of-manager.md#L131-L132
8e59887
to
70df377
Compare
/assign @vincepri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/milestone v0.8.x
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
since controller-runtime v0.8.1, manager start all caches before other Runnables so this function is not need anymore cf kubernetes-sigs/controller-runtime#1327 Signed-off-by: Vincent Gramer <vincent@kubermatic.com>
… controllers (#9168) * remove function util.IsCacheNotStarted since controller-runtime v0.8.1, manager start all caches before other Runnables so this function is not need anymore cf kubernetes-sigs/controller-runtime#1327 Signed-off-by: Vincent Gramer <vincent@kubermatic.com> * master-controller-manager/usersshkeyssynchronizer/controller.go: remove unecessary check since controller-runtime v0.8.1 the manager start all cache before running runables, so this error can not happen. Signed-off-by: Vincent Gramer <vincent@kubermatic.com> * master-controller-manager/project-label-synchronizer/project_label_synchronizer.go: remove unecessary check since controller-runtime v0.8.1 the manager start all cache before running runables, so this error can not happen. Signed-off-by: Vincent Gramer <vincent@kubermatic.com> * master-controller-manager/master-constraint-template-controller/controller.go: remove unecessary check since controller-runtime v0.8.1 the manager start all cache before running runables, so this error can not happen. Signed-off-by: Vincent Gramer <vincent@kubermatic.com> * master-controller-manager/master-constraint-controller/controller.go: remove unecessary check since controller-runtime v0.8.1 the manager start all cache before running runables, so this error can not happen. Signed-off-by: Vincent Gramer <vincent@kubermatic.com> * master-controller-manager/cluster-template-synchronizer/controller.go: remove unecessary check since controller-runtime v0.8.1 the manager start all cache before running runables, so this error can not happen. Signed-off-by: Vincent Gramer <vincent@kubermatic.com>
This pr implements the second half of the "Move cluster-specific code
out of the manager" proposal: Making it start all caches before other
Runnables and not just the one of the main Cluster.