-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 fix DestWritter var name typo #1340
Conversation
This lost another |
This was the issue, to replace |
Yes but you changed |
Oh sorry. That's by mistake, will fix it. |
I defer to others if this is worth fixing with a compat break. The field probably isn't used a ton or we would have noticed this sooner? If we want compat, a more complex fix will be needed. /lgtm |
its fine if we don't need it, I can close the PR, was just trying to find an easy first PR to do to get familiar with the repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How hard would it be to add a new DestWriter field, deprecate the misspelled one, and do whatever is necessary to ensure they’re interchangeable (preferring DestWriter if they’re both set), and then remove DestWritter in a later release?
should not be too hard, will work on that and update PR, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @alvaroaleman
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nader-ziada, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
DestWritter
toDestWriter
Fixes: #1294