-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 allow fakeclient to patch CR with no RV #2725
🐛 allow fakeclient to patch CR with no RV #2725
Conversation
Hi @alexandremahdhaoui. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
57c612a
to
d357c36
Compare
d357c36
to
6574e9d
Compare
Signed-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>
6574e9d
to
3a19b11
Compare
/ok-to-test |
Thx! /lgtm |
LGTM label has been added. Git tree hash: c3d84995b9825e753818b3cd1dfb3691a9ec5ae7
|
/assign @alvaroaleman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexandremahdhaoui, alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Context
This PR should fix a bug #2678 where patching a resource would throw a conflict error when the new object doesn't specify any RV.
Changes