Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 allow fakeclient to patch CR with no RV #2725

Conversation

alexandremahdhaoui
Copy link
Contributor

@alexandremahdhaoui alexandremahdhaoui commented Mar 24, 2024

Context

This PR should fix a bug #2678 where patching a resource would throw a conflict error when the new object doesn't specify any RV.

Changes

  • Fix patch by setting the new accessors' RV to the old accessors' RV.
  • Add test to ensure the correct behavior

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @alexandremahdhaoui. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 24, 2024
@alexandremahdhaoui alexandremahdhaoui force-pushed the fix_fakeclient-patch-with-no-rv-should-succeed branch from 57c612a to d357c36 Compare March 24, 2024 14:10
pkg/client/patch.go Outdated Show resolved Hide resolved
@alexandremahdhaoui alexandremahdhaoui force-pushed the fix_fakeclient-patch-with-no-rv-should-succeed branch from d357c36 to 6574e9d Compare March 26, 2024 14:13
Signed-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>
@alexandremahdhaoui alexandremahdhaoui force-pushed the fix_fakeclient-patch-with-no-rv-should-succeed branch from 6574e9d to 3a19b11 Compare March 26, 2024 14:14
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2024
@sbueringer
Copy link
Member

Thx!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c3d84995b9825e753818b3cd1dfb3691a9ec5ae7

@sbueringer
Copy link
Member

/assign @alvaroaleman

Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandremahdhaoui, alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 67b27f2 into kubernetes-sigs:main Apr 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants