Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Containerd default set SystemdCgroup is true, cri-tools test faild #1292

Closed
lengrongfu opened this issue Nov 13, 2023 · 4 comments · Fixed by #1302
Closed

When Containerd default set SystemdCgroup is true, cri-tools test faild #1292

lengrongfu opened this issue Nov 13, 2023 · 4 comments · Fixed by #1302
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@lengrongfu
Copy link
Contributor

What happened:

ci: https://github.com/containerd/containerd/actions/runs/6841588084/job/18602143108?pr=9350
When Containerd default set SystemdCgroup is true, the generated cgroupsPath is invalid.

Nov 12 15:46:57.970: INFO: Unexpected error occurred: rpc error: code = Unknown desc = failed to start sandbox "31ebf25aed49dcfb889acea7a7dbfdf09b65bb8deeeb4011b9a809f92660bae8": failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: expected cgroupsPath to be of format "slice:prefix:name" for systemd cgroups, got "/k8s.io/31ebf25aed49dcfb889acea7a7dbfdf09b65bb8deeeb4011b9a809f92660bae8" instead: unknown
  [FAILED] in [It] - github.com/kubernetes-sigs/cri-tools/pkg/framework/util.go:217 @ 11/12/23 15:46:57.97

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Container runtime or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Others:
@lengrongfu lengrongfu added kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Nov 13, 2023
@lengrongfu
Copy link
Contributor Author

containerd pr: containerd/containerd#9350

@lengrongfu
Copy link
Contributor Author

/assign

@akhilerm
Copy link
Contributor

akhilerm commented Dec 5, 2023

@lengrongfu Can this be of use here kubernetes/kubernetes#118770, getting the cgroup driver from the container runtime itself.

@lengrongfu
Copy link
Contributor Author

I submitted a PR, please review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants