From fc1b54318ffabca4550370f1037554d360446598 Mon Sep 17 00:00:00 2001 From: Amir Alavi Date: Wed, 19 Jun 2024 15:34:04 -0400 Subject: [PATCH] fix: helm leader-election typo to `resourceNamespace` Signed-off-by: Amir Alavi --- charts/descheduler/templates/_helpers.tpl | 6 ++++-- charts/descheduler/values.yaml | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/charts/descheduler/templates/_helpers.tpl b/charts/descheduler/templates/_helpers.tpl index fb540d0f03..5e0baab85d 100644 --- a/charts/descheduler/templates/_helpers.tpl +++ b/charts/descheduler/templates/_helpers.tpl @@ -87,8 +87,10 @@ Leader Election {{- if .Values.leaderElection.resourceName }} - --leader-elect-resource-name={{ .Values.leaderElection.resourceName }} {{- end }} -{{- if .Values.leaderElection.resourceNamescape }} -- --leader-elect-resource-namespace={{ .Values.leaderElection.resourceNamescape }} +{{/* resource namespace value starts with a typo so keeping resourceNamescape for backwards compatibility */}} +{{- $resourceNamespace := default .Values.leaderElection.resourceNamespace .Values.leaderElection.resourceNamescape -}} +{{- if $resourceNamespace -}} +- --leader-elect-resource-namespace={{ $resourceNamespace }} {{- end -}} {{- end }} {{- end }} diff --git a/charts/descheduler/values.yaml b/charts/descheduler/values.yaml index 7013ce52ff..5d86f066ff 100644 --- a/charts/descheduler/values.yaml +++ b/charts/descheduler/values.yaml @@ -70,7 +70,7 @@ leaderElection: {} # retryPeriod: 2s # resourceLock: "leases" # resourceName: "descheduler" -# resourceNamescape: "kube-system" +# resourceNamespace: "kube-system" command: - "/bin/descheduler"