Migrate all e2es to run descheduler as an image

[ingvagabund]

With #1474 we can run the descheduler through a pod. End-to-end testing is not intended to run the descheduler code directly, as this does not accurately reflect its operation in production.
Each e2e test can be refactored separately. #1472 is an example of the first step running the descheduler as a whole. While #1474 gives idea on how to run it as a deployment.

The following e2es need to be migrated:

• TestRemoveDuplicates
• TestFailedPods
• TestLeaderElection
• TestTopologySpreadConstraint
• TestClientConnectionConfiguration

[ingvagabund]

@jklaw90 @JaneLiuL @fanhaouu @pravarag @eminaktas @zhifei92 @googs1025 in case you would like to contribute

[fanhaouu]

@jklaw90 @JaneLiuL @fanhaouu @pravarag @eminaktas @zhifei92 @googs1025 in case you would like to contribute

Not sure if there is an ETA, I can make some contributions. @ingvagabund

[ingvagabund]

There's no ETA. Also, there's no guarantee the issue will stay unresolved for long. I will eventually migrate all the e2es to simplify #1466.

[fanhaouu]

There's no ETA. Also, there's no guarantee the issue will stay unresolved for long. I will eventually migrate all the e2es to simplify #1466.

ok

[hsunwenfang]

Hi @ingvagabund
I would like to contribute, thx!

[ingvagabund]

@hsunwenfang thank you. Any of the listed items is currently for taking.

[fanhaouu]

I have completed some E2E tests, but encountered some issues when running the E2E tests locally. I am still debugging and working on resolving them.
@ingvagabund @ingvagabund

[hsunwenfang]

Hi @ingvagabund
I'm working on TestLeaderElection and is refering your commit
ab467a5
Where in L57 the "sigs.k8s.io/descheduler/pkg/framework/plugins/removepodshavingtoomanyrestarts" is imported
While there is no corresponding folder for leaderelection
Should "sigs.k8s.io/descheduler/pkg/framework/plugins/defaultevictor" be used instead?
Or should there be another way to do it
Thanks!!

[googs1025]

Hi @ingvagabund I'm working on TestLeaderElection and is refering your commit ab467a5 Where in L57 the "sigs.k8s.io/descheduler/pkg/framework/plugins/removepodshavingtoomanyrestarts" is imported While there is no corresponding folder for leaderelection Should "sigs.k8s.io/descheduler/pkg/framework/plugins/defaultevictor" be used instead? Or should there be another way to do it Thanks!!

Can you provide more information? If you are working on this issue, you can also raise a WIP PR to ask the question.

[hsunwenfang]

Hi @googs1025
Thanks for the instruction
WIP PR raised and added detail to my ask there
#1497 (comment)

[ingvagabund]

@hsunwenfang dropped comments in the wip pr :)

@fanhaouu do the issues reproduce only locally?

[fanhaouu]

@hsunwenfang dropped comments in the wip pr :)

@fanhaouu do the issues reproduce only locally?

In theory, it should also exist online. There's an issue with some of the code you wrote. I'll make some adjustments, and you can review it later.For example, the current container E2E test didn't meet expectations, but it still shows as 'pass'.

[fanhaouu]

done: #1500