From 5f557b5d0eb445dad584838e471ef79142d6cd13 Mon Sep 17 00:00:00 2001 From: Steve Kriss Date: Wed, 7 Sep 2022 15:23:52 +0000 Subject: [PATCH] replace Attached condition with Accepted in HTTPRoute docs The HTTPRoute docs have several references to an "Attached" condition, however this condition does not exist for routes. Replaces these references with the appropriate "Accepted" condition. Signed-off-by: Steve Kriss --- apis/v1alpha2/httproute_types.go | 16 ++++---- apis/v1beta1/httproute_types.go | 16 ++++---- .../gateway.networking.k8s.io_httproutes.yaml | 40 +++++++++---------- .../gateway.networking.k8s.io_httproutes.yaml | 24 +++++------ 4 files changed, 48 insertions(+), 48 deletions(-) diff --git a/apis/v1alpha2/httproute_types.go b/apis/v1alpha2/httproute_types.go index 082794d1ca..b470829320 100644 --- a/apis/v1alpha2/httproute_types.go +++ b/apis/v1alpha2/httproute_types.go @@ -249,7 +249,7 @@ type HTTPRouteRule struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the -// Attached Condition for the Route to `status: False`, with a +// Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // +kubebuilder:validation:Enum=Exact;PathPrefix;RegularExpression @@ -311,7 +311,7 @@ type HTTPPathMatch struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the -// Attached Condition for the Route to `status: False`, with a +// Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // +kubebuilder:validation:Enum=Exact;RegularExpression @@ -392,7 +392,7 @@ type HTTPHeaderMatch struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the -// Attached Condition for the Route to `status: False`, with a +// Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // +kubebuilder:validation:Enum=Exact;RegularExpression @@ -451,7 +451,7 @@ type HTTPQueryParamMatch struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the -// Attached Condition for the Route to `status: False`, with a +// Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // +kubebuilder:validation:Enum=GET;HEAD;POST;PUT;DELETE;CONNECT;OPTIONS;TRACE;PATCH @@ -558,7 +558,7 @@ type HTTPRouteFilter struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the - // Attached Condition for the Route to `status: False`, with a + // Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // +unionDiscriminator @@ -784,7 +784,7 @@ type HTTPPathModifier struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the - // Attached Condition for the Route to `status: False`, with a + // Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // @@ -828,7 +828,7 @@ type HTTPRequestRedirectFilter struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the - // Attached Condition for the Route to `status: False`, with a + // Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // +optional @@ -871,7 +871,7 @@ type HTTPRequestRedirectFilter struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the - // Attached Condition for the Route to `status: False`, with a + // Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // +optional diff --git a/apis/v1beta1/httproute_types.go b/apis/v1beta1/httproute_types.go index 02faedad8d..7f5e06aac8 100644 --- a/apis/v1beta1/httproute_types.go +++ b/apis/v1beta1/httproute_types.go @@ -248,7 +248,7 @@ type HTTPRouteRule struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the -// Attached Condition for the Route to `status: False`, with a +// Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // +kubebuilder:validation:Enum=Exact;PathPrefix;RegularExpression @@ -310,7 +310,7 @@ type HTTPPathMatch struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the -// Attached Condition for the Route to `status: False`, with a +// Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // +kubebuilder:validation:Enum=Exact;RegularExpression @@ -391,7 +391,7 @@ type HTTPHeaderMatch struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the -// Attached Condition for the Route to `status: False`, with a +// Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // +kubebuilder:validation:Enum=Exact;RegularExpression @@ -450,7 +450,7 @@ type HTTPQueryParamMatch struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the -// Attached Condition for the Route to `status: False`, with a +// Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // +kubebuilder:validation:Enum=GET;HEAD;POST;PUT;DELETE;CONNECT;OPTIONS;TRACE;PATCH @@ -557,7 +557,7 @@ type HTTPRouteFilter struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the - // Attached Condition for the Route to `status: False`, with a + // Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // +unionDiscriminator @@ -783,7 +783,7 @@ type HTTPPathModifier struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the - // Attached Condition for the Route to `status: False`, with a + // Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // @@ -827,7 +827,7 @@ type HTTPRequestRedirectFilter struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the - // Attached Condition for the Route to `status: False`, with a + // Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // +optional @@ -870,7 +870,7 @@ type HTTPRequestRedirectFilter struct { // must ensure that unknown values will not cause a crash. // // Unknown values here must result in the implementation setting the - // Attached Condition for the Route to `status: False`, with a + // Accepted Condition for the Route to `status: False`, with a // Reason of `UnsupportedValue`. // // +optional diff --git a/config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml b/config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml index d207fa4a60..95ce58a993 100644 --- a/config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml +++ b/config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml @@ -535,7 +535,7 @@ spec: implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation - setting the Attached Condition for the + setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: @@ -562,7 +562,7 @@ spec: values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result - in the implementation setting the Attached + in the implementation setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: @@ -577,7 +577,7 @@ spec: implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation setting - the Attached Condition for the Route to `status: + the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: - 301 @@ -613,7 +613,7 @@ spec: Note that values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in - the implementation setting the Attached Condition + the implementation setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: @@ -673,7 +673,7 @@ spec: implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation - setting the Attached Condition for the + setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: @@ -1046,7 +1046,7 @@ spec: to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation - setting the Attached Condition for the Route + setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: @@ -1073,7 +1073,7 @@ spec: to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation setting the - Attached Condition for the Route to `status: False`, + Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: - http @@ -1086,7 +1086,7 @@ spec: values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the - implementation setting the Attached Condition for + implementation setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: - 301 @@ -1120,7 +1120,7 @@ spec: that values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation - setting the Attached Condition for the Route to `status: + setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: - RequestHeaderModifier @@ -1175,7 +1175,7 @@ spec: to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation - setting the Attached Condition for the Route + setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: @@ -2138,7 +2138,7 @@ spec: implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation - setting the Attached Condition for the + setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: @@ -2165,7 +2165,7 @@ spec: values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result - in the implementation setting the Attached + in the implementation setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: @@ -2180,7 +2180,7 @@ spec: implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation setting - the Attached Condition for the Route to `status: + the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: - 301 @@ -2216,7 +2216,7 @@ spec: Note that values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in - the implementation setting the Attached Condition + the implementation setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: @@ -2276,7 +2276,7 @@ spec: implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation - setting the Attached Condition for the + setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: @@ -2648,7 +2648,7 @@ spec: to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation - setting the Attached Condition for the Route + setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: @@ -2675,7 +2675,7 @@ spec: to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation setting the - Attached Condition for the Route to `status: False`, + Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: - http @@ -2688,7 +2688,7 @@ spec: values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the - implementation setting the Attached Condition for + implementation setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: - 301 @@ -2722,7 +2722,7 @@ spec: that values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation - setting the Attached Condition for the Route to `status: + setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: - RequestHeaderModifier @@ -2777,7 +2777,7 @@ spec: to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation - setting the Attached Condition for the Route + setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: diff --git a/config/crd/standard/gateway.networking.k8s.io_httproutes.yaml b/config/crd/standard/gateway.networking.k8s.io_httproutes.yaml index 1aa6a09ba6..faae67d29f 100644 --- a/config/crd/standard/gateway.networking.k8s.io_httproutes.yaml +++ b/config/crd/standard/gateway.networking.k8s.io_httproutes.yaml @@ -485,7 +485,7 @@ spec: values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result - in the implementation setting the Attached + in the implementation setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: @@ -500,7 +500,7 @@ spec: implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation setting - the Attached Condition for the Route to `status: + the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: - 301 @@ -536,7 +536,7 @@ spec: Note that values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in - the implementation setting the Attached Condition + the implementation setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: @@ -888,7 +888,7 @@ spec: to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation setting the - Attached Condition for the Route to `status: False`, + Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: - http @@ -901,7 +901,7 @@ spec: values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the - implementation setting the Attached Condition for + implementation setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: - 301 @@ -935,7 +935,7 @@ spec: that values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation - setting the Attached Condition for the Route to `status: + setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: - RequestHeaderModifier @@ -1817,7 +1817,7 @@ spec: values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result - in the implementation setting the Attached + in the implementation setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: @@ -1832,7 +1832,7 @@ spec: implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation setting - the Attached Condition for the Route to `status: + the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: - 301 @@ -1868,7 +1868,7 @@ spec: Note that values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in - the implementation setting the Attached Condition + the implementation setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: @@ -2219,7 +2219,7 @@ spec: to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation setting the - Attached Condition for the Route to `status: False`, + Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: - http @@ -2232,7 +2232,7 @@ spec: values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the - implementation setting the Attached Condition for + implementation setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`." enum: - 301 @@ -2266,7 +2266,7 @@ spec: that values may be added to this enum, implementations must ensure that unknown values will not cause a crash. \n Unknown values here must result in the implementation - setting the Attached Condition for the Route to `status: + setting the Accepted Condition for the Route to `status: False`, with a Reason of `UnsupportedValue`. \n " enum: - RequestHeaderModifier