Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webhook validation to ensure that ReplacePathPrefix in rewrites has corresponding prefix match #1166

Closed
robscott opened this issue May 18, 2022 · 2 comments · Fixed by #1171
Closed

Add webhook validation to ensure that ReplacePathPrefix in rewrites has corresponding prefix match #1166

robscott opened this issue May 18, 2022 · 2 comments · Fixed by #1171
Assignees
@robscott
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.5.0

Comments

@robscott
Copy link
Member

When a URLRewrite filter is specified on a Route rule and it includes ReplacePathPrefix configuration, we should verify that exactly one path prefix match is specified on the same Route rule. We should also verify that no other path matches are specified as part of this.
@robscott robscott added the kind/feature Categorizes issue or PR as related to a new feature. label May 18, 2022
@robscott robscott mentioned this issue May 18, 2022
Closed
@robscott robscott added this to the v0.5.0 milestone May 18, 2022
@robscott robscott added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 18, 2022
@robscott
Copy link
Member Author

This work should probably be based on #1124, or just wait for that PR to merge.

@robscott robscott mentioned this issue May 19, 2022
Merged
@robscott
Copy link
Member Author

/assign

@robscott robscott mentioned this issue May 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robscott robscott

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Adding validation to ensure prefix path match exists for path modifier robscott/gateway-api
1 participant
@robscott