Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move error status code to 500 #1200

Closed
youngnick opened this issue Jun 10, 2022 · 5 comments · Fixed by #1208 or #1209
Closed

Move error status code to 500 #1200

youngnick opened this issue Jun 10, 2022 · 5 comments · Fixed by #1208 or #1209
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@youngnick
Copy link
Contributor

What would you like to be added:

In various places, we've documented that having no endpoints available should variously be 404 or 503. @thockin suggested in the v0.5.0 API Review that we should consider 502 instead.

This issue covers agreeing that's the case, and then implementing that change.

Why this is needed:
Need to get breaking behavior changes done before we release v0.5.0.

@youngnick youngnick added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 10, 2022
@youngnick youngnick added this to the v0.5.0 milestone Jun 10, 2022
@mehabhalodiya
Copy link
Contributor

@youngnick This needs to be done only in v1beta1 or in v1alpha2 also?
I caught 404 in v1beta1/httproute_types.go. Not sure, which other files to look at!

@mehabhalodiya
Copy link
Contributor

I would like to take up this one.
/assign

@youngnick
Copy link
Contributor Author

In both please, we will keep the v1alpha2 and v1beta1 in sync for this release.

@youngnick
Copy link
Contributor Author

We agreed that:

  • If there are no matching routes, a 404 should be generated
  • f there are matching routes but no/missing backends/endpoints to route to, a 500 (specifically) should be generated.

@mikemorris is going to write out a list of the different cases, and check we haven't missed anything.

@youngnick youngnick changed the title Move error status code to 502 Move error status code to 500 Jun 13, 2022
@mehabhalodiya mehabhalodiya removed their assignment Jun 14, 2022
@dpasiukevich
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
3 participants